Skip to content

Centralize EC middleware finalize lifecycle#554

Closed
ChristianPavilonis wants to merge 1 commit intofeature/partner-registrationfrom
feature/ec-middleware
Closed

Centralize EC middleware finalize lifecycle#554
ChristianPavilonis wants to merge 1 commit intofeature/partner-registrationfrom
feature/ec-middleware

Conversation

@ChristianPavilonis
Copy link
Collaborator

@ChristianPavilonis ChristianPavilonis commented Mar 24, 2026

Summary

  • Centralize EC lifecycle finalization so all routes apply cookie and KV side effects consistently instead of duplicating route-specific behavior.
  • Move EC context parsing to router prelude and thread shared context through publisher, integration proxy, and auction paths to enforce Story 5 route semantics.
  • Keep /auction read-only for EC generation while preserving consent-gated identity forwarding and documenting that behavior explicitly.

Changes

File Change
crates/trusted-server-core/src/ec/finalize.rs Add centralized EC response finalization helpers for cookie set/clear, withdrawal tombstone writes, mismatch reconciliation, and last-seen updates.
crates/trusted-server-core/src/ec/mod.rs Extend EcContext with pre-read geo support, shared generation API with optional KV write-through, and helper accessors for finalize logic.
crates/trusted-server-adapter-fastly/src/main.rs Pre-read EcContext/geo/KV in router, pass context through handlers, and apply ec_finalize_response before common response finalization.
crates/trusted-server-core/src/publisher.rs Remove local EC parsing/mutation and consume router-provided mutable EC context plus optional KV graph.
crates/trusted-server-core/src/integrations/registry.rs Remove per-route response cookie/header mutation, use shared mutable EC context, and update integration route tests accordingly.
crates/trusted-server-core/src/auction/endpoints.rs Switch to read-only EC context consumption and document that auction does not generate new EC IDs in Story 5 flow.
docs/guide/configuration.md Apply Prettier table-spacing normalization required for docs format gate.

Closes

Closes #538

Test plan

  • cargo test --workspace
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo fmt --all -- --check
  • JS tests: cd crates/js/lib && npx vitest run
  • JS format: cd crates/js/lib && npm run format
  • Docs format: cd docs && npm run format
  • WASM build: cargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1
  • Manual testing via fastly compute serve
  • Other: N/A

Checklist

  • Changes follow CLAUDE.md conventions
  • No unwrap() in production code — use expect("should ...")
  • Uses tracing macros (not println!)
  • New code has tests
  • No secrets or credentials committed

@ChristianPavilonis ChristianPavilonis self-assigned this Mar 24, 2026
@ChristianPavilonis
Centralize EC lifecycle finalization in middleware
e0cdf94 
Implement Story 5 (#538): centralize EC cookie set/delete and KV
tombstone writes in finalize_response(), replacing inline mutation
scattered across publisher and proxy handlers. Adds consent-withdrawal
cleanup, EC header propagation on proxy requests, and docs formatting.
@ChristianPavilonis ChristianPavilonis force-pushed the feature/partner-registration branch from 5820c8d to 011bfea Compare March 26, 2026 00:00
@ChristianPavilonis
Copy link
Collaborator Author

ChristianPavilonis commented Mar 26, 2026

Superseded by #582 which consolidates the full EC epic into a single PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ChristianPavilonis ChristianPavilonis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ChristianPavilonis